cosign: Make verify-blob compatible with sigstore-python #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This changes cosign::verify_blob() cert argument: it is no longer PEM that is base64 encoded (on top of the encoding that is part of being a PEM), instead it is PEM as already documented. * verify-blob now works with certificates that are PEM or base64 PEM * verify-blob also trims signature This makes verify-blob work with python-tuf outputs. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
|
I'm not invested in this specific fix, just making improvements to get familiar with the code base. So feel free to suggest alternative approaches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes verify-blob work with python-tuf outputs as well as the cosign outputs.
Fixes #288
Note that this changes the "cosign API": I imagined that this is mostly an internal module but if that is something you want to not change then this approach is probably not good.