Examples: Add a minimal example of bundle sign/verify #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jku
commented
Oct 17, 2024
examples/bundle/main.rs
Outdated
Comment on lines
95
to
97
| println!( | ||
| "Created signature bundle {} with identity {}", | ||
| &bundle_path, email |
There was a problem hiding this comment.
I'd love to print something that would contain the correct verification command:
Signed README.md. To verify use
$ cargo run --example bundle verify --identity name@example.com --issuer https://github.com/login/oauth README.md
But that's not currently possible since the issuer does not seem to be exposed (#409).
This uses * sigstore::bundle to sign and verify * sigstore::oauth to get a signing token Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
commented
Oct 17, 2024
| println!("Failed to create signature bundle {}: {}", bundle_path, e); | ||
| std::process::exit(1); | ||
| }); | ||
| let token = authorize(); |
There was a problem hiding this comment.
Should maybe add a println! here that hints that a browser will be opened for the auth...
jku
commented
Oct 17, 2024
Don't use display() when creating a new path, instead use PathBuf.set_file_name() Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add example of
sigstore::bundleuse to make it more visible that sigstore-rs does make it easy to use the new bundle format (as well as to automatically update the trust root). More specifically the example usesFixes #406
Release Note
sigstore::bundleuse-->
Documentation
See included README.md and
--helpoutput