Extract all the GitHub related information from signature certs #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The certificates issued by Fulcio include some custom x509 extensions when `cosign verify` is ran inside of a GitHub Action. Starting from this commit, all these extra attributes are extracted from the certificate and stored inside of the `CertificateSignature` object. This allows the creation of more fine-tuned validation constraints for signatures produced inside of GitHub Actions. Signed-off-by: Flavio Castelli <fcastelli@suse.com> Co-authored-by: Víctor Cuadrado Juan <viccuad@users.noreply.github.com>
viccuad
approved these changes
May 23, 2022
flavio
deleted the
signature-layer-extract-all-the-github-related-extensions-from-fulcio-issued-certificate
branch
viccuad
added a commit
to viccuad/policy-fetcher
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The certificates issued by Fulcio include some custom x509 extensions when
cosign verifyis ran inside of a GitHub Action.Starting from this commit, all these extra attributes are extracted from the certificate and stored inside of the
CertificateSignatureobject.This allows the creation of more fine-tuned validation constraints for signatures produced inside of GitHub Actions.