perf: swap order of escape regexes to avoid lookahead (#546)

* swap regex order to avoid lookahead * changelog * changelog formatting apparently
siimon · Mar 8, 2023 · 199b7d1 · 199b7d1
1 parent 4ddf9a2
commit 199b7d1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,9 @@ project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
+- Refactor `escapeString` helper in `lib/registry.js` to improve performance and
+  avoid an unnecessarily complex regex.
+
 ### Added
 
 ## [14.2.0] - 2023-03-06

diff --git a/lib/registry.js b/lib/registry.js
@@ -2,7 +2,7 @@
 const { getValueAsString } = require('./util');
 
 function escapeString(str) {
-	return str.replace(/\n/g, '\\n').replace(/\\(?!n)/g, '\\\\');
+	return str.replace(/\\/g, '\\\\').replace(/\n/g, '\\n');
 }
 function escapeLabelValue(str) {
 	if (typeof str !== 'string') {