Set aggregation method for newer event loop metrics #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you're saying, the aggregation method isn't ideal. For the mean it should actually be fine, as the sample size should actually be the same for all cluster nodes, right? Maybe you want to add a short note about these concerns to the respective Readme section to set the right expectations. |
These are not entirely accurate: they're the "mean of the mean" and "mean of percentiles," but that's as good as we can get. Fixes siimon#418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not entirely accurate: they're the "mean of the mean" and "mean of percentiles," but that's as good as we can get.
No tests added - doesn't seem worth asserting that these properties are set.
Fixes #418