Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cluster metrics when AggregatorReg isn't created on workers #464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix cluster metrics when AggregatorReg isn't created on workers #464

wants to merge 1 commit into from
+95 −59

Commits on Sep 19, 2021

  1. fix cluster metrics when AggregatorReg isn't created on workers 

    When using the cluster module, you must now call `promclient.setupClusterWorker()` from each cluster worker.

v13.2.0 introduced a change from v13.1.0 that broke cluster metrics if an `AggregatorRegistry` was not instantiated on each cluster worker. The example in `examples/cluster.js` shows instantiation of an `AggregatorRegistry` in the workers, so users following that example were not affected by this change. However, the example was not written as intended: `new AggregatorRegistry()` should only be called on the cluster master. `examples/cluster.js` has been updated to show the full, correct usage.
    @zbjornson
    zbjornson committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    4b1efb5 View commit details
    Browse the repository at this point in the history