Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript definitions for using with Registry<OpenMetricsContentType> #571

Merged
merged 4 commits into from
May 13, 2023

Conversation

FreeRiderBysik
Copy link
Contributor

@FreeRiderBysik FreeRiderBysik commented May 13, 2023

  1. Content types was mixed up - ContentTypes in index.d.ts are mixed up #565
  2. Methods like collectDefaultMetrics without setting generic type does not allows to work with Registry

@SimenB SimenB linked an issue May 13, 2023 that may be closed by this pull request
Copy link
Collaborator

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContentTypes in index.d.ts are mixed up
2 participants