-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly copy & paste data with context menu, and handle number notion that is based on locale #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TypeScript config: noEmitOnError: true, for dev purposes - Prettier: maxWidth: 120
- may not work for arabic number notations
- create function that will get decimal and thousand separators - replace these separators in strings passed as an stringNumber argument
- create helper-function that will get decimal and thousand separators - replace these separators in strings passed as an stringNumber argument - replace all characters (like "USD", or "$", etc.) before and after numbers
fix after-merge conflict
fix: re-write parseLocaleNumber - create helper-function that will get decimal and thousand separators - replace these separators in strings passed as an stringNumber argument - replace all characters (like "USD", or "$", etc.) before and after numbers
…s/reactgrid into v4-fix/context-menu-paste
…s/reactgrid into v4-fix/context-menu-paste
…s/reactgrid into v4-fix/context-menu-paste
- fix issue no. #282
- fix issue no. #282
…s/reactgrid into v4-fix/context-menu-paste
…s/reactgrid into v4-fix/context-menu-paste
…s/reactgrid into v4-fix/context-menu-paste
feat: getRowsFromClipboard function - fixes issue #282
This was referenced Dec 28, 2023
Added missing types, error handles, moved parts of the logic to separate functions, renamed functions and variables to better indicate their purpose
DLowHP
requested changes
Dec 28, 2023
DLowHP
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context menu copy-pasting
Parse number with respecting locale number notion
Respect the locale settings for user-supplied numerical data, whether pasted or entered manually.