add hold detection functionality #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michota
requested changes
Feb 14, 2024
src/controllers/handlePointerDown.ts
Outdated
|
|
||
| let holdTimeoutId: NodeJS.Timeout; | ||
|
|
||
| if (event.button === 2 || usedTouch) { |
There was a problem hiding this comment.
If the event is a right-click or a touch event, a timeout is set to trigger. holdTimeoutId is used to clear the timeout if a pointer up event occurs before 500 ms, so the hold handler function will not be called
There was a problem hiding this comment.
Okay. Can you create some sort of constant assertion or simply a normal const that will describe event.button === 2, so the code will be easier to understand?
There was a problem hiding this comment.
Yup, it's a good idea
Michota
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detectHold function that handles the detection and completion of a hold action for both mouse and touch pointer types.
It includes the following features:
hold detection: this could be a right mouse click or a touch event. It sets up an interval to check the duration of the hold and listens for a pointer up event.
hold completion: when a pointer up event occurs, the function terminates the hold detection process. If the hold duration was 200 milliseconds or more, it resolves a promise to indicate that the hold action has been completed.