Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LT-21894: Show Import Phonology command only in Grammar area #145

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented Aug 28, 2024

I also made the Export Phonology command only appear in the Grammar area. Unfortunately, this means that the Export Grammar Sketch commands have to only appear in the Grammar area, too.


This change is Reviewable

Copy link
Contributor

@JakeOliver28 JakeOliver28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3)


Src/xWorks/FwXWindow.cs line 1941 at r1 (raw file):

			{
				display.Enabled = true;
				display.Visible = true;

Could we set display.Enabled = area == "grammar" and also get rid of display.Enabled = false at the beginning of the method?

Copy link
Contributor

@JakeOliver28 JakeOliver28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3)


Src/xWorks/FwXWindow.cs line 1941 at r1 (raw file):

Previously, JakeOliver28 (Jake Oliver) wrote…

Could we set display.Enabled = area == "grammar" and also get rid of display.Enabled = false at the beginning of the method?

The same goes for display.Visible

@JakeOliver28 JakeOliver28 enabled auto-merge (squash) August 28, 2024 18:32
Copy link
Contributor

@JakeOliver28 JakeOliver28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3)

@JakeOliver28 JakeOliver28 merged commit c067800 into release/9.1 Aug 28, 2024
4 of 5 checks passed
@JakeOliver28 JakeOliver28 deleted the LT-21894 branch August 28, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants