Word Export LT-21830: Fix indentation issues

[mark-sil]

Many of the code changes were a result of Word not allowing nested paragraphs. As a result, all paragraphs need to be moved to first level elements in the Body.

• Add paragraphs instead of starting a new line.
• Nested content like sub-senses still result in a new paragraph.
• Removed condition from GenerateWordStyleFromLcmStyleSheet() that was preventing nodes under senses from indenting correctly (examples).
• The basedOn value can now come from either the styles basedOn value or from the parent node.

Change-Id: Ibf9faba0ad79131100a7783d258a26429a9513d5

---

This change is 

[jasonleenaylor]

Src/xWorks/LcmWordGenerator.cs line 2227 at r1 (raw file):

			var workingParagraph = outputParagraph;
			var elements = ((DocFragment)contentToAdd).DocBody.Elements();
			foreach (OpenXmlElement elem in elements)

What is the behavior if we encounter two un-nestable elements back to back? If it isn't harmful we don't need to do anything really.

[jasonleenaylor]

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, all discussions resolved

---

Src/xWorks/LcmWordGenerator.cs line 1778 at r1 (raw file):

					{
						style.BasedOn.Val = basedOnStyle.StyleId;
						if(continuationStyle && style.BasedOn.Val != WordStylesGenerator.NormalParagraphStyleName)

If you intend that we will fix this method to work with continuationStyle then I approve of this change, if you don't think we need it for that we should remove any use of continuationStyle after the Assert and return.

[mark-sil]

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @jasonleenaylor)

---

Src/xWorks/LcmWordGenerator.cs line 1778 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

If you intend that we will fix this method to work with continuationStyle then I approve of this change, if you don't think we need it for that we should remove any use of continuationStyle after the Assert and return.

Right now, I don’t know of a situation that requires it, but I’m kind of guessing it will be needed, so I left it in.

---

Src/xWorks/LcmWordGenerator.cs line 2227 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

What is the behavior if we encounter two un-nestable elements back to back? If it isn't harmful we don't need to do anything really.

Multiple un-nestable elements back to back is not a problem. Each will be in it's own paragraph, then when/if we encounter nestable elements a continuation paragraph is started.

[jasonleenaylor]

Src/xWorks/LcmWordGenerator.cs line 1778 at r1 (raw file):

Previously, mark-sil (Mark Kidder) wrote…

Right now, I don’t know of a situation that requires it, but I’m kind of guessing it will be needed, so I left it in.

👍

[jasonleenaylor]

Reviewable status: 0 of 3 files reviewed, all discussions resolved