-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix interlinear flextext importing #154
Conversation
*Correct display of morphemes, lex. entries, lex. gloss, and lex. info
Not sure how or why this changed, but we should revert it. |
Remove if unnecessary |
move the repo defs outside of the loop. |
make a variable for itemDict["txt"].Item2 - var morphForm |
Instead of firstordefault check the bundle at the index (properly guarded) |
Verify that null is possible, if not remove this check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 8 unresolved discussions
Src/LexText/Interlinear/BIRDInterlinearImporter.cs
line 823 at r2 (raw file):
entry = entries.FirstOrDefault(m => m.HomographNumber.ToString() == itemDict["hn"].Item2); } else // Didn't find a match
Skip import if there are multiple entries but we aren't importing with a homograph number
Code quote:
Didn't find a match
Src/LexText/Interlinear/BIRDInterlinearImporter.cs
line 825 at r2 (raw file):
else // Didn't find a match { break;
I think continue is better here.
…ev/FieldWorks into feature/improveFlexImport
This change is