Word Export: Add missing Before/After/Between content

[mark-sil]

• Add between content for CrossRreference types.
• Add before and after content for LexicalRelations->Targets.

Note: I think passing child to AddCollection() is the correct node for the collection being added. The other implementations of AddCollection() do not use this parameter so they are not affected.

This fixes one of the issues identified in LT-21808.

---

This change is 

[JakeOliver28]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @mark-sil)

---

Src/xWorks/ConfiguredLcmGenerator.cs line 2008 at r1 (raw file):

			// Now that we have things in the right order, try outputting one type at a time
			bool first = true;

Could we call this firstIteration or isFirstIteration? Took me a second to figure out the purpose/meaning of this variable. And same thing for the parameter first in all the BetweenCrossReferenceType methods.

---

Src/xWorks/LcmJsonGenerator.cs line 414 at r1 (raw file):

		}

		public void BetweenCrossReferenceType(IFragment content, ConfigurableDictionaryNode node, bool first)

Is this method necessary? We just implement it because of the method being added to the interface, correct? Do we need to add the method to the interface, or could we only implement it in the class that uses it?

[mark-sil]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @JakeOliver28)

---

Src/xWorks/ConfiguredLcmGenerator.cs line 2008 at r1 (raw file):

Previously, JakeOliver28 (Jake Oliver) wrote…

Could we call this firstIteration or isFirstIteration? Took me a second to figure out the purpose/meaning of this variable. And same thing for the parameter first in all the BetweenCrossReferenceType methods.

I change the name based on the context. Sometimes firstIteration and sometimes firstItem.

---

Src/xWorks/LcmJsonGenerator.cs line 414 at r1 (raw file):

Previously, JakeOliver28 (Jake Oliver) wrote…

Is this method necessary? We just implement it because of the method being added to the interface, correct? Do we need to add the method to the interface, or could we only implement it in the class that uses it?

The caller doesn't know that it is calling a LcmWordGenerator, All it knows is that it is calling some type of ILcmContentGenerator, so to continue with the existing pattern we need to use the interface.

[JakeOliver28]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions