Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LT-21888: boundary marker name can be deleted when editing rules #165

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented Sep 23, 2024

I have a fix for this, but it might not be the best solution.

If you select a boundary marker (or any phoneme) in a phonological rule and type a character, its name gets deleted but the boundary marker does not. I couldn't track down where in the code this happens. I prevented this from happening by suppressing all characters except for Backspace and Delete. This means that the user can only enter phonemes by using the menu provided. This feels like overkill, but Matthew is OK with it if we eventually add code to allow phonemes to be entered by typing.


This change is Reviewable

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)


Src/LexText/LexTextControls/PatternView.cs line 141 at r1 (raw file):

				if (RemoveItemsRequested != null)
					RemoveItemsRequested(this, new RemoveItemsRequestedEventArgs(false));
				e.Handled = true;

For correctness move e.Handled = true above the if. By returning and ignoring we are 'handling' the key press, and the event should reflect this.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jasonleenaylor jasonleenaylor enabled auto-merge (squash) September 26, 2024 20:51
@jasonleenaylor jasonleenaylor merged commit fe01516 into release/9.1 Sep 26, 2024
4 of 5 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-21888 branch September 26, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants