Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gram info dropdown: LT-21584 Part2 #173

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

aror92
Copy link
Contributor

@aror92 aror92 commented Oct 3, 2024

Fix behavior of grammatical info dropdown in the New Entry dialogue.

  • Correct the variable used to overwrite width in ShowDropDownBox() in the case that width is explicitly specified for the listbox.
  • Specify DropDownWidth for the MainPOS dropdown to match the default width for popuptree.
  • The AffixTypes dropdown is meant to match button width, so its DropDownWidth should not be explicitly set.

This change is Reviewable

Fix behavior of grammatical info dropdown
in the New Entry dialogue.

- Correct the variable used to overwrite width in ShowDropDownBox()
in the case that width is explicitly specified for the listbox.
- Specify DropDownWidth for the MainPOS dropdown to match the
default width for popuptree.
- The affixtypes dropdown is meant to match button width,
so the DropDownWidth should not be explicitly set.

Change-Id: Iffe8cd83ac8b47d464c28c29f79ea9193ff9be9c
@aror92 aror92 enabled auto-merge (squash) October 3, 2024 21:19
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aror92)

@aror92 aror92 merged commit e9130cf into release/9.1 Oct 4, 2024
4 of 5 checks passed
@aror92 aror92 deleted the LT-21584-Part2 branch October 4, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants