Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word Export LT-21942: Fix picture clipping problem #177

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

mark-sil
Copy link
Contributor

@mark-sil mark-sil commented Oct 9, 2024

Runs containing drawings (pictures) need to be in their own Paragraph. When we are in SeparateIntoFirstLevelElements() don’t combine them with other elements in a paragraph. Instead leave the run as a first level element so that later, in AddEntryData(), it will get put in its own paragraph with the correct style.

Change-Id: Ie62eb2edb7547d553018a61ea57b638dc146d407


This change is Reviewable

mark-sil and others added 2 commits October 9, 2024 12:39
Runs containing drawings (pictures) need to be in their own
Paragraph. When we are in SeparateIntoFirstLevelElements()
don’t combine them with other elements in a paragraph.  Instead
leave the run as a first level element so that later, in
AddEntryData(), it will get put in its own paragraph with the
correct style.

Change-Id: Ie62eb2edb7547d553018a61ea57b638dc146d407
@JakeOliver28 JakeOliver28 enabled auto-merge (squash) October 9, 2024 17:36
Copy link
Contributor

@JakeOliver28 JakeOliver28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@JakeOliver28 JakeOliver28 merged commit 34f608c into release/9.1 Oct 9, 2024
4 of 5 checks passed
@JakeOliver28 JakeOliver28 deleted the LT-21942c branch October 9, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants