Use real MongoDB connection for E2E tests #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmunn
force-pushed
the
feat/real-mongodb-for-e2e
branch
from
fdd6641
to
698447f
Compare
Base automatically changed from
feat/end-to-end-testing-with-lexbox
to
develop
August 26, 2024 08:11
In E2E tests, the SetInputSystems call would fail because there is no existing project record in the freshly-created, empty Mongo instance. We don't want to change LfMerge to create the project record, because the Language Forge code is responsible for doing that. So instead we simply skip the update if the project record doesn't exist, allowing E2E tests to pass while not changing the behavior of real code.
Also print instructions for deleting it once post-failure investigation is completed.
rmunn
force-pushed
the
feat/real-mongodb-for-e2e
branch
from
4acb402
to
46caa50
Compare
hahn-kev
requested changes
Aug 27, 2024
* Always stop Mongo container * Throw if Mongo container fails to start * Simpler MongoDbHostAndPort property definition
Unless the flag is set (to a non-empty value) the Mongo container will be torn down even if tests have failed.
hahn-kev
reviewed
Aug 27, 2024
hahn-kev
requested changes
Aug 27, 2024
hahn-kev
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #345.
The end-to-end LfMerge tests now use a real MongoDB container (spun up and torn down for each test, with no data persistence) rather than a mock Mongo connection. This does require the presence of Docker on the machine running the E2E tests, so that
docker run mongo:6will succeed.