Skip to content

Commit

Permalink
Update Python versions: remove 3.8, 3.9; add 3.11 (#2510)
Browse files Browse the repository at this point in the history
Co-Authored-By: Jim Grady <jimgrady.jg@gmail.com>
  • Loading branch information
imnasnainaec and jmgrady authored Sep 5, 2023
1 parent a23a1fe commit 55f4416
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.10", "3.11"]
steps:
# See https://docs.stepsecurity.io/harden-runner/getting-started/ for instructions on
# configuring harden-runner and identifying allowed endpoints.
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# User guide build environment
FROM python:3.11.5-bookworm AS user_guide_builder
FROM python:3.10.12-slim-bookworm AS user_guide_builder

ENV PYTHONDONTWRITEBYTECODE 1
ENV PYTHONUNBUFFERED 1
Expand All @@ -16,7 +16,7 @@ COPY docs/user_guide docs/user_guide
RUN tox -e user-guide

# Frontend build environment.
FROM node:18.17-bullseye-slim AS frontend_builder
FROM node:18.17.1-bookworm-slim AS frontend_builder
WORKDIR /app

# Install app dependencies.
Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,9 @@ A rapid word collection tool. See the [User Guide](https://sillsdev.github.io/Th
### Python
_Python 3_ is required to run the scripts that are used to initialize and maintain the cluster. Note that the commands
for setting up the virtual environment must be run from the top-level directory for _The Combine_ source tree.
_Python_ (3.10 recommended) is required to run the scripts that are used to initialize and maintain the cluster. Note
that the commands for setting up the virtual environment must be run from the top-level directory for _The Combine_
source tree.
#### Windows Python Installation
Expand Down
2 changes: 0 additions & 2 deletions scripts/cleanup_local_repo.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
The purpose of this script is to get a developer back to a clean baseline in
the event their repository state does not match other developers or CI.
Requirements: Python 3.8+
"""

from pathlib import Path
Expand Down
3 changes: 1 addition & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ extend-exclude = node_modules, venv
# tox-gh-actions configuration.
[gh-actions]
python =
3.8: lint
3.9: lint
3.10: lint, fmt-check, type-check, user-guide
3.11: lint

[tox]
envlist =
Expand Down

0 comments on commit 55f4416

Please sign in to comment.