Skip to content

Commit

Permalink
[PermissionServiceTests] Avoid using Role.None in general tests
Browse files Browse the repository at this point in the history
  • Loading branch information
imnasnainaec committed Apr 17, 2024
1 parent 278cbf1 commit 5e1b2d6
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions Backend.Tests/Services/PermissionServiceTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ public void HasProjectPermissionTestProjectPermFalse()
{
var user = new User();
var httpContext = CreateHttpContextWithUser(user);
var userRole = _userRoleRepo.Create(new UserRole { ProjectId = ProjId, Role = Role.None }).Result;
var userRole = _userRoleRepo.Create(new UserRole { ProjectId = ProjId, Role = Role.Harvester }).Result;
user.ProjectRoles[ProjId] = userRole.Id;
_ = _userRepo.Update(user.Id, user).Result;
Assert.That(_permService.HasProjectPermission(httpContext, Permission.WordEntry, ProjId).Result, Is.False);
Assert.That(_permService.HasProjectPermission(httpContext, Permission.Import, ProjId).Result, Is.False);
}

[Test]
Expand All @@ -129,18 +129,18 @@ public void ContainsProjectRoleTestAdmin()
public void ContainsProjectRoleTestNoProjectRole()
{
var httpContext = CreateHttpContextWithUser(new User());
Assert.That(_permService.ContainsProjectRole(httpContext, Role.None, ProjId).Result, Is.False);
Assert.That(_permService.ContainsProjectRole(httpContext, Role.Harvester, ProjId).Result, Is.False);
}

[Test]
public void ContainsProjectRoleTestProjectRoleFalse()
{
var user = new User();
var httpContext = CreateHttpContextWithUser(user);
var userRole = _userRoleRepo.Create(new UserRole { ProjectId = ProjId, Role = Role.None }).Result;
var userRole = _userRoleRepo.Create(new UserRole { ProjectId = ProjId, Role = Role.Harvester }).Result;
user.ProjectRoles[ProjId] = userRole.Id;
_ = _userRepo.Update(user.Id, user).Result;
Assert.That(_permService.ContainsProjectRole(httpContext, Role.Harvester, ProjId).Result, Is.False);
Assert.That(_permService.ContainsProjectRole(httpContext, Role.Editor, ProjId).Result, Is.False);
}

[Test]
Expand Down

0 comments on commit 5e1b2d6

Please sign in to comment.