Skip to content

Commit

Permalink
Merge branch 'master' into eslintrc
Browse files Browse the repository at this point in the history
  • Loading branch information
imnasnainaec authored Nov 6, 2023
2 parents 9adbdd0 + 3b54858 commit a6e5707
Show file tree
Hide file tree
Showing 10 changed files with 929 additions and 808 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export default function DropWord(props: DropWordProps): ReactElement {

// reset vern if not in vern list
if (treeWord && !verns.includes(treeWord.vern)) {
dispatch(setVern(props.wordId, verns[0] || ""));
dispatch(setVern({ wordId: props.wordId, vern: verns[0] || "" }));
}

return (
Expand All @@ -69,7 +69,12 @@ export default function DropWord(props: DropWordProps): ReactElement {
variant="standard"
value={treeWord.vern}
onChange={(e) =>
dispatch(setVern(props.wordId, e.target.value as string))
dispatch(
setVern({
wordId: props.wordId,
vern: e.target.value as string,
})
)
}
>
{verns.map((vern) => (
Expand All @@ -94,7 +99,7 @@ export default function DropWord(props: DropWordProps): ReactElement {
<FlagButton
flag={treeWord.flag}
updateFlag={(newFlag: Flag) => {
dispatch(flagWord(props.wordId, newFlag));
dispatch(flagWord({ wordId: props.wordId, flag: newFlag }));
}}
buttonId={`word-${props.wordId}-flag`}
/>
Expand Down
20 changes: 16 additions & 4 deletions src/goals/MergeDuplicates/MergeDupsStep/MergeDragDrop/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,13 @@ export default function MergeDragDrop(): ReactElement {
// Case 2a: Cannot merge a protected sense into another sense.
if (sourceId !== res.combine.droppableId) {
// The target sense is in a different word, so move instead of combine.
dispatch(moveSense(senseRef, res.combine.droppableId, 0));
dispatch(
moveSense({
ref: senseRef,
destWordId: res.combine.droppableId,
destOrder: 0,
})
);
}
return;
}
Expand All @@ -66,7 +72,7 @@ export default function MergeDragDrop(): ReactElement {
// Case 2b: If the target is a sidebar sub-sense, it cannot receive a combine.
return;
}
dispatch(combineSense(senseRef, combineRef));
dispatch(combineSense({ src: senseRef, dest: combineRef }));
} else if (res.destination) {
const destId = res.destination.droppableId;
// Case 3: The sense was dropped in a droppable.
Expand All @@ -77,7 +83,13 @@ export default function MergeDragDrop(): ReactElement {
return;
}
// Move the sense to the dest MergeWord.
dispatch(moveSense(senseRef, destId, res.destination.index));
dispatch(
moveSense({
ref: senseRef,
destWordId: destId,
destOrder: res.destination.index,
})
);
} else {
// Case 3b: The source & dest droppables are the same, so we reorder, not move.
const order = res.destination.index;
Expand All @@ -90,7 +102,7 @@ export default function MergeDragDrop(): ReactElement {
// If the sense wasn't moved or was moved within the sidebar above a protected sense, do nothing.
return;
}
dispatch(orderSense(senseRef, order));
dispatch(orderSense({ ref: senseRef, order: order }));
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/goals/MergeDuplicates/MergeDupsTreeTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ export function newMergeTreeWord(
}

export function convertSenseToMergeTreeSense(
sense?: Sense,
sense: Sense,
srcWordId = "",
order = 0
): MergeTreeSense {
return {
...(sense ?? newSense()),
...sense,
srcWordId,
order,
protected: sense?.accessibility === Status.Protected,
Expand Down
Loading

0 comments on commit a6e5707

Please sign in to comment.