Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement formatted translations #2075

Closed
imnasnainaec opened this issue Apr 25, 2023 · 0 comments · Fixed by #2084
Closed

Implement formatted translations #2075

imnasnainaec opened this issue Apr 25, 2023 · 0 comments · Fixed by #2084
Assignees
@imnasnainaec
Labels
font/language

Comments

@imnasnainaec
Copy link
Collaborator

Especially in preparation for right-to-left languages, some of our strings need to make use of https://www.i18next.com/translation-function/formatting

In the project statistics ProgressBar, we have (e.g.)Domains Collected: 1294 which is implemented with

        <ListItemText primary={t("statistics.wordsCollected")} />
        <Typography>{totalWordCount}</Typography>

but should probably be something like

 <ListItemText primary={t("statistics.wordsCollected", {val: totalWordCount})} />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imnasnainaec imnasnainaec

Labels
font/language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Arabic and rtl lang support sillsdev/TheCombine
1 participant
@imnasnainaec