Add Arabic and rtl lang support #2084
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2084 +/- ##
==========================================
+ Coverage 48.91% 48.95% +0.03%
==========================================
Files 297 297
Lines 9460 9479 +19
Branches 693 699 +6
==========================================
+ Hits 4627 4640 +13
- Misses 4269 4275 +6
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Setting "dir="rtl" makes the footer of the MaterialTable very confusing: material-table-core/core#760 |
There was a problem hiding this comment.
Reviewed 2 of 7 files at r1, 1 of 8 files at r2, 2 of 34 files at r3.
Reviewable status: 5 of 44 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
public/locales/es/translation.json line 221 at r3 (raw file):
"stepMerge": "Merge Set", "of": "de" }
Not current with English.
Code quote:
"progress": {
"step": "Paso",
"stepMerge": "Merge Set",
"of": "de"
}
There was a problem hiding this comment.
Reviewable status: 5 of 44 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jasonleenaylor)
public/locales/es/translation.json line 221 at r3 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
Not current with English.
Anything not present in another language will default to English, and this will get updated correctly when we cycle everything through Crowdin.
There was a problem hiding this comment.
Reviewed 3 of 7 files at r1, 3 of 8 files at r2, 21 of 34 files at r3, 14 of 14 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
There was a problem hiding this comment.
Reviewed 11 of 11 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
src/i18n.ts line 34 at r5 (raw file):
interpolation: { escapeValue: false }, }, setDir
comment here that this is a callback would be good.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r6, all commit messages.
Reviewable status:
Resolves #2075
Also fixes the third part of #2048
This change is