Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MergeDups] Don't lose other language info when merging senses #3166

Closed
imnasnainaec opened this issue Jun 14, 2024 · 0 comments · Fixed by #3181
Closed

[MergeDups] Don't lose other language info when merging senses #3166

imnasnainaec opened this issue Jun 14, 2024 · 0 comments · Fixed by #3181
Assignees

Comments

@imnasnainaec
Copy link
Collaborator

imnasnainaec commented Jun 14, 2024

When senses are combined in the Merge Duplicates tool, semantic domains and definitions from all senses are preserved, but only glosses from the first sense are kept.

When two senses are supposed to be the same sense but just have the gloss in different language, combining them should keep the gloss in both languages.

Acceptance test:

  • Open a project with no duplicates that appear in Data Cleanup > Merge Duplicates
  • Create two words with identical vernacular form and glosses in two different languages
    • E.g., vernacular form: "vern"; first word with English gloss "worm" and second word with Spanish gloss "gusano"
    • To create these two words:
      • Go to Data Entry, select a domain, and enter the first word
      • Go to project settings > Languages > Analysis and change the top analysis language
      • Return to Data Entry, select a domain, and enter the second word
  • Data Cleanup > Merge Duplicates
  • Drag and drop the sense from one of the words onto the sense in the other word.
  • Click the "Save & Continue" button
  • Data Cleanup > Review Entries
  • Verify that there is just one entry with vernacular form "vern" and that it has a single sense with both glosses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant