Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve more content when merging senses #3181

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 26, 2024

Resolves #3166


This change is Reviewable

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.23%. Comparing base (3f8db49) to head (3d2a61a).

Files Patch % Lines
...rc/goals/MergeDuplicates/Redux/reducerUtilities.ts 84.21% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3181      +/-   ##
==========================================
+ Coverage   75.13%   75.23%   +0.10%     
==========================================
  Files         275      275              
  Lines       10413    10431      +18     
  Branches     1231     1237       +6     
==========================================
+ Hits         7824     7848      +24     
+ Misses       2231     2226       -5     
+ Partials      358      357       -1     
Flag Coverage Δ
backend 84.38% <ø> (+0.14%) ⬆️
frontend 67.05% <84.21%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as draft June 27, 2024 13:31
@imnasnainaec imnasnainaec marked this pull request as ready for review June 27, 2024 15:05
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) June 28, 2024 21:41
@imnasnainaec imnasnainaec merged commit 551bfe7 into master Jun 28, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the merge-preserve-content branch June 28, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MergeDups] Don't lose other language info when merging senses
2 participants