Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notes field to Word #755

Closed
4 of 5 tasks
johnthagen opened this issue Oct 9, 2020 · 6 comments · Fixed by #756 or #768
Closed
4 of 5 tasks

Add Notes field to Word #755

johnthagen opened this issue Oct 9, 2020 · 6 comments · Fixed by #756 or #768

Comments

@johnthagen
Copy link
Collaborator

johnthagen commented Oct 9, 2020

Backend

  • Extend Word Model to support saving a string note field in addition to the note's language (bcp-47 code string).
  • Round trip the note content with the Lift import & export.

Frontend

  • Extend Word and ReviewEntriewWord to support a note field.
  • Do not expose selecting the note's language, instead default to the project's current analysis language.
  • In Review Entries, add a note column, where notes can be added, viewed, edited.
@johnthagen
Copy link
Collaborator Author

An example note from FieldWorks:

<note>
<form lang="en"><text>Note in English</text></form>
</note>

@imnasnainaec
Copy link
Collaborator

Note support in Lift import & export still needed.

@johnthagen
Copy link
Collaborator Author

I can work on Lift import/export Friday if that is not too late. Happy to defer to @jasonleenaylor if he wants to pick it up.

@johnthagen
Copy link
Collaborator Author

Lift import of Words happens here:

var resp = parser.ReadLiftFile(extractedLiftPath.FirstOrDefault());

@johnthagen
Copy link
Collaborator Author

Lift import logic implemented in LiftMerger class:

private sealed class LiftMerger : ILexiconMerger<LiftObject, LiftEntry, LiftSense, LiftExample>

@johnthagen
Copy link
Collaborator Author

Note contents are parsed and presented in this method:

public void MergeInNote(LiftObject extensible, string type, LiftMultiText contents, string rawXml) { }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment