Add Word.note field

[imnasnainaec]

Resolves #755

This change is 

[johnthagen]

@imnasnainaec Is there a way if a Note is entered that we give it more space? Either vertically or horizontally?

[johnthagen]

@imnasnainaec When I add a note, confirm and then edit again, the previous note contents are not shown.

[imnasnainaec]

@imnasnainaec Is there a way if a Note is entered that we give it more space? Either vertically or horizontally?

@johnthagen Just pushed a fix for that.

[imnasnainaec]

@imnasnainaec When I add a note, confirm and then edit again, the previous note contents are not shown.

@johnthagen Curious. I'm not experiencing the same behavior.

[johnthagen]

Just pushed a fix for that.

Confirmed fixed.

[johnthagen]

Curious. I'm not experiencing the same behavior.

I am no longer able to reproduce it either.

[johnthagen]

---

src/goals/ReviewEntries/ReviewEntriesComponent/CellComponents/CellColumns.tsx, line 15 at r8 (raw file):

enum SortStyle {
  // vernacular, noteText: neither have a customSort defined,
  // so there is currently no way to trigger their SortStyles.

Is this the column sort option in the table? I am able to click the arrow next to Note and have it sort. Should this not work?

[johnthagen]

---

src/goals/ReviewEntries/ReviewEntriesComponent/CellComponents/CellColumns.tsx, line 11 at r8 (raw file):

There are a lot of uses of : any in this file. Can any of them be converted to a stronger type?

[imnasnainaec]

Reviewable status: 20 of 22 files reviewed, 1 unresolved discussion (waiting on @johnthagen)

---

src/goals/ReviewEntries/ReviewEntriesComponent/CellComponents/CellColumns.tsx, line 11 at r8 (raw file):

Previously, johnthagen wrote…

There are a lot of uses of : any in this file. Can any of them be converted to a stronger type?

Improved

---

src/types/word.tsx, line 39 at r8 (raw file):

Previously, johnthagen wrote…

(I could be mistaken about the purpose/function of this function).

For the bare type definitions, "" is best.

[johnthagen]

Reviewed 2 of 2 files at r10, 1 of 1 files at r11.
Reviewable status: complete! all files reviewed, all discussions resolved

[jasonleenaylor]

At first glance it looks good (might give it a more thorough look_. Should we handle the Lift Import/Export in a second PR?

Reviewable status: 16 of 22 files reviewed, all discussions resolved (waiting on @johnthagen)

[jasonleenaylor]

Reviewable status: 16 of 22 files reviewed, 2 unresolved discussions (waiting on @imnasnainaec and @johnthagen)

---

Backend/Models/Word.cs, line 187 at r11 (raw file):

The language used the note is written in.

I'd probably write it as:
The bcp-47 code for the language the note is written in.

---

src/resources/translations.json, line 439 at r11 (raw file):

noNot

Changing ids isn't kind to Crowdin translators, so we should avoid it in the future. Now is probably a good time for this though. :)

[jasonleenaylor]

Reviewed 8 of 9 files at r12, 1 of 1 files at r13.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @imnasnainaec)

[imnasnainaec]

Reviewable status: 21 of 23 files reviewed, all discussions resolved (waiting on @jasonleenaylor and @johnthagen)

---

Backend/Models/Word.cs, line 187 at r11 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

The language used the note is written in.

I'd probably write it as:
The bcp-47 code for the language the note is written in.

Done.

---

src/resources/translations.json, line 439 at r11 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

noNot

Changing ids isn't kind to Crowdin translators, so we should avoid it in the future. Now is probably a good time for this though. :)

Affirmative.

[johnthagen]

Reviewed 2 of 2 files at r14.
Reviewable status: complete! all files reviewed, all discussions resolved

[johnthagen]

@jasonleenaylor

Should we handle the Lift Import/Export in a second PR?

I looked into LiftMerger.FinishEntry and when I use the example you sent us, the entry.Notes field wasn't filled in. I'm not super familiar with the SIL Lift parsing stack, so I think you'll probably need to take a look at this one. I would enjoy reviewing what you do to learn from though.

[jasonleenaylor]

Reviewed 3 of 3 files at r15.
Reviewable status: complete! all files reviewed, all discussions resolved

[imnasnainaec]

Reviewed 1 of 19 files at r7, 10 of 19 files at r8, 1 of 2 files at r10, 1 of 1 files at r11, 7 of 9 files at r12, 1 of 1 files at r13, 2 of 2 files at r14, 2 of 3 files at r15, 1 of 1 files at r16.
Reviewable status: complete! all files reviewed, all discussions resolved