Major goal- and step-loading refactor. #1004
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1004 +/- ##
==========================================
- Coverage 49.62% 49.58% -0.05%
==========================================
Files 236 236
Lines 6480 6508 +28
Branches 393 391 -2
==========================================
+ Hits 3216 3227 +11
- Misses 2974 2995 +21
+ Partials 290 286 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Reviewed 19 of 19 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @imnasnainaec)
Backend/Controllers/UserEditController.cs, line 223 at r1 (raw file):
Console.WriteLine(stepEdit.StepIndex);
Remove the debugging statements, here and below.
Backend/Models/UserEdit.cs, line 79 at r1 (raw file):
public int? StepIndex { get; set; }
The intended use of undefined should be documented here.
src/components/GoalTimeline/tests/GoalTimelineComponent.test.tsx, line 50 at r1 (raw file):
"Goes default for a non-existent goalType
My brain didn't like this, re-word?
There was a problem hiding this comment.
Reviewable status: 15 of 19 files reviewed, 3 unresolved discussions (waiting on @jasonleenaylor)
Backend/Controllers/UserEditController.cs, line 223 at r1 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
Console.WriteLine(stepEdit.StepIndex);Remove the debugging statements, here and below.
Done.
Backend/Models/UserEdit.cs, line 79 at r1 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
public int? StepIndex { get; set; }The intended use of undefined should be documented here.
Done.
src/components/GoalTimeline/tests/GoalTimelineComponent.test.tsx, line 50 at r1 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
"Goes default for a non-existent goalTypeMy brain didn't like this, re-word?
Done.
There was a problem hiding this comment.
Reviewed 7 of 7 files at r2, 4 of 4 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
Backend:
Frontend:
backend.tsxfunction correspondingly;GoalTimeline/GoalDisplay/create new goals to avoid mutating suggestion list, disable buttons to completed goals;GoalTimeline/GoalsActions.tsx, especially goal loading and step advancing functions;MergeDupStepComponent.tsx, don't refresh words (leave that to general goal actions), load filler text if nothing to merge (will need a proper page);types/goals.tsx, give empty first step by default, replace v1 (time-based) with v4 (random) to prevent duplicate hashes when goal history loadedCloses #186 *
Closes #588
Closes #990
First 1.5 boxes of #931
Related to #393, #458 , #725 (*more needed to handle in-progress multi-step goals)
This change is