-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backup improvements #1005
Backup improvements #1005
Conversation
Move to backup time to accommodate west coast users.
Enable only installing/updating the backup configuration by specifying: -t backups on ansible-playbook command line.
1. common combine-env script for setting common environment variables and functions 2. rename combine-cleanup to combine-clean-aws 3. send backup output to rsyslog instead of email (default) 4. remove import/export zip files before backup 5. remove shutdown/restart of backend and database for backup
Color coding shows up as escape characters in syslog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 12 files at r1.
Reviewable status: 6 of 12 files reviewed, all discussions resolved (waiting on @jmgrady)
deploy/roles/combine_backup/defaults/main.yml, line 2 at r1 (raw file):
# backup_hour: 7 # backup_minute: 15 max_backups: 3
The hour in this comment doesn't match the 10 in deploy/group_vars/server/main.yaml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 12 files reviewed, all discussions resolved (waiting on @jmgrady)
deploy/roles/combine_backup/defaults/main.yml, line 2 at r1 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
# backup_hour: 7 # backup_minute: 15 max_backups: 3
The hour in this comment doesn't match the 10 in
deploy/group_vars/server/main.yaml.
The comment is intended to show the names of variables to be defined to enable the backups. I have added some text to explain this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 12 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Implements the following improvements to the backup process for TheCombine:
bin/combine-env
script (currently shared by the backup and restore processes)./deploy/vars/packages.yml
backend
anddatabase
containers as part of the backup.This change is