Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Edit, Goal, CharInventoryCreation #1008

Merged
merged 14 commits into from
Feb 15, 2021
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 11, 2021

Resolves #636
Resolves #924

Partial progress on #931.


This change is Reviewable

@codecov-io
Copy link

codecov-io commented Feb 11, 2021

Codecov Report

Merging #1008 (d334919) into master (0d3e543) will decrease coverage by 5.83%.
The diff coverage is 45.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
- Coverage   50.04%   44.21%   -5.84%     
==========================================
  Files         236      194      -42     
  Lines        6512     3155    -3357     
  Branches      391      402      +11     
==========================================
- Hits         3259     1395    -1864     
+ Misses       2966     1464    -1502     
- Partials      287      296       +9     
Flag Coverage Δ
backend ?
frontend 44.21% <45.74%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/backend/index.tsx 5.03% <0.00%> (+0.07%) ⬆️
src/components/GoalTimeline/GoalsActions.tsx 83.58% <ø> (-1.15%) ⬇️
...harInventoryCreation/CharacterInventoryReducer.tsx 24.32% <ø> (ø)
...nents/CharacterDetail/CharacterDetailComponent.tsx 0.00% <ø> (ø)
...ation/components/CharacterDetail/CharacterInfo.tsx 0.00% <0.00%> (ø)
...s/CharacterDetail/CharacterStatusControl/index.tsx 0.00% <0.00%> (ø)
...tion/components/CharacterDetail/CharacterWords.tsx 0.00% <0.00%> (ø)
...reation/components/CharacterList/CharacterCard.tsx 0.00% <ø> (ø)
...omponents/CharacterList/CharacterListComponent.tsx 38.88% <ø> (ø)
...n/components/CharacterList/CharacterStatusText.tsx 0.00% <0.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3e543...d334919. Read the comment docs.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 24 of 25 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give user feedback on saved Character Inventory. Inconsistent Save button in create character inventory
3 participants