Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frontend Word and Project data types to match the backend #1019

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Feb 12, 2021

Several type definitions in the frontend are not up to date with the backend. This is causing some data to flow through the frontend and back to the backend without it being apparent in the frontend that this is happening (JSON fields are being passed around that are persisted, but not reflected in the types).

  • Also reorder the definitions to match the backend to make it easier to verify in the future

This syncing problem is something that OpenAPI solves.


This change is Reviewable

@johnthagen johnthagen added bug Something isn't working frontend labels Feb 12, 2021
@johnthagen johnthagen self-assigned this Feb 12, 2021
Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)

@johnthagen johnthagen merged commit f4e86d7 into master Feb 12, 2021
@johnthagen johnthagen deleted the fix-frontend-data-types branch February 12, 2021 20:29
imnasnainaec added a commit that referenced this pull request Feb 15, 2021
Fix for bug introduced in #1019 preventing new words from being created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants