Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AppBar and GoalTimeline response to different window widths. #1032

Merged
merged 5 commits into from
Feb 22, 2021

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 22, 2021

Also, fixes #699

Updated AppBar
xs:
Screen Shot 2021-02-22 at 13 44 47
sm:
Screen Shot 2021-02-22 at 13 45 06
md+:
Screen Shot 2021-02-22 at 13 45 19


This change is Reviewable

@codecov-io
Copy link

codecov-io commented Feb 22, 2021

Codecov Report

Merging #1032 (d262efa) into master (5b507b5) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1032   +/-   ##
=======================================
  Coverage   50.29%   50.29%           
=======================================
  Files         226      226           
  Lines        6589     6589           
  Branches      402      402           
=======================================
  Hits         3314     3314           
  Misses       2979     2979           
  Partials      296      296           
Flag Coverage Δ
backend 55.96% <ø> (ø)
frontend 44.11% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/AppBar/AppBarComponent.tsx 100.00% <ø> (ø)
src/components/AppBar/Logo.tsx 50.00% <ø> (ø)
src/components/AppBar/NavigationButtons.tsx 33.33% <ø> (ø)
src/components/AppBar/ProjectNameButton.tsx 66.66% <0.00%> (ø)
src/components/AppBar/UserMenu.tsx 47.82% <ø> (ø)
src/components/GoalTimeline/GoalList.tsx 66.66% <ø> (ø)
.../components/GoalTimeline/GoalTimelineComponent.tsx 80.76% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b507b5...d262efa. Read the comment docs.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm assuming the GoalTimeline looks good too. 😄

Reviewed 7 of 7 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 1c4b763 into master Feb 22, 2021
@imnasnainaec imnasnainaec deleted the visual-nudge branch February 22, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add username next to avatar in the AppBar
3 participants