Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin isort #1243

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Unpin isort #1243

merged 3 commits into from
Jul 8, 2021

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Jul 8, 2021

Unpin isort now that upstream PyCQA/isort#1762 has been resolved.

Also use --check alias in tox config so that isort CLI matches similar black CLI arguments.


This change is Reviewable

@johnthagen johnthagen added python dependencies Pull requests that update a dependency file labels Jul 8, 2021
@johnthagen johnthagen requested a review from jmgrady July 8, 2021 13:11
@johnthagen johnthagen self-assigned this Jul 8, 2021
@codecov-commenter

This comment has been minimized.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)

@johnthagen johnthagen merged commit 8e475c6 into master Jul 8, 2021
@johnthagen johnthagen deleted the update-isort branch July 8, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants