Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LangingPage] Add paragraph with call-to-action, sign-up button #1616

Merged
merged 5 commits into from
Mar 18, 2022

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Mar 17, 2022

Resolves #1604, step 2.


This change is Reviewable

@johnthagen
Copy link
Collaborator


src/components/LandingPage/index.tsx, line 87 at r1 (raw file):

}

function SignUpButton() {

Add return type annotation?

@johnthagen
Copy link
Collaborator


src/components/LandingPage/index.tsx, line 87 at r1 (raw file):

Previously, johnthagen wrote…

Add return type annotation?

(Applies to all functions in this file)

@johnthagen
Copy link
Collaborator


src/resources/translations.json, line 43 at r1 (raw file):

    ],
    "descriptionP4": [
      "Are you organizing or assisting with word collection? Or do you have RWC data that needs to be cleaned up? To get started with The Combine: ",

I would add a line break before To get started with The Combine: (or perhaps this should be translated as a separate paragraph. The call to action and button placement currently read a little odd based on the width of the screen.

Should the button also be on its on line and centered?

Screenshot 2022-03-18 081657.png

@johnthagen
Copy link
Collaborator


src/resources/translations.json, line 43 at r1 (raw file):

Previously, johnthagen wrote…

I would add a line break before To get started with The Combine: (or perhaps this should be translated as a separate paragraph. The call to action and button placement currently read a little odd based on the width of the screen.

Should the button also be on its on line and centered?

Screenshot 2022-03-18 081657.png

Also, maybe want to make the final sentence more imperative?

"Get started with The Combine by signing up" ?

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #1616 (151d784) into master (555605e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1616      +/-   ##
==========================================
- Coverage   52.33%   52.33%   -0.01%     
==========================================
  Files         272      272              
  Lines        8336     8337       +1     
  Branches      607      607              
==========================================
  Hits         4363     4363              
- Misses       3486     3487       +1     
  Partials      487      487              
Flag Coverage Δ
backend 80.00% <ø> (ø)
frontend 32.73% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/LandingPage/BottomBar.tsx 75.00% <ø> (ø)
src/components/LandingPage/LandingButtons.tsx 58.33% <0.00%> (-5.31%) ⬇️
src/components/LandingPage/TopBar.tsx 100.00% <ø> (ø)
src/components/LandingPage/index.tsx 100.00% <ø> (ø)
src/components/Login/LoginPage/LoginComponent.tsx 58.62% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555605e...151d784. Read the comment docs.

@imnasnainaec imnasnainaec marked this pull request as ready for review March 18, 2022 18:56
Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor and @johnthagen)


src/resources/translations.json, line 43 at r1 (raw file):

Previously, johnthagen wrote…

Also, maybe want to make the final sentence more imperative?

"Get started with The Combine by signing up" ?

Done.

@lgtm-com
Copy link

lgtm-com bot commented Mar 18, 2022

This pull request introduces 2 alerts when merging 151d784 into 555605e - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

Copy link
Collaborator

@johnthagen johnthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 2 of 4 files at r2, 7 of 7 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jasonleenaylor)

@imnasnainaec imnasnainaec merged commit 5650b65 into master Mar 18, 2022
@imnasnainaec imnasnainaec deleted the landing-page-p4 branch March 18, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the landing page experience
3 participants