Update image_repo references #1680
Conversation
Replace references to input.image_repo with the new input names: - image_registry, and - image_registry_alias
This is to test the change.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jmgrady)
.github/actions/combine-deploy-update/action.yml line 5 at r1 (raw file):
inputs: image_registry: description: "Docker Image Repository"
Update description too?
Code quote:
"Docker Image Repository"
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @jmgrady)
.github/actions/combine-deploy-update/action.yml line 5 at r1 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
Update description too?
Done.
Codecov Report
@@ Coverage Diff @@
## master #1680 +/- ##
==========================================
+ Coverage 52.16% 52.32% +0.16%
==========================================
Files 272 275 +3
Lines 8436 8498 +62
Branches 616 616
==========================================
+ Hits 4401 4447 +46
- Misses 3541 3558 +17
+ Partials 494 493 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jmgrady)
.github/actions/combine-deploy-update/action.yml line 36 at r2 (raw file):
run: kubectl --context ${{ inputs.kube_context }} set image deployment/frontend frontend="${{ inputs.image_registry }}${{ inputs.image_registry_alias}}/combine_frontend:${{ inputs.image_tag }}"
So there's no / or : or anything else separating these two things?
Code quote:
${{ inputs.image_registry }}${{ inputs.image_registry_alias}}
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jmgrady)
.github/actions/combine-deploy-update/action.yml line 36 at r2 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
So there's no / or : or anything else separating these two things?
Correct. The / is part of the image_registry_alias. For the private registry (builds for the QA server) there is no image_registry_alias; for the public registry, there is one. I did not include the alias as part of the image_registry because during the build process, we login to the image_registry so that the images can be pushed to the registry. During the login, the alias is not part of the login command.
I have updated the description to indicate that the / should be in the image_registry_alias.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
Change
Replace references to input.image_repo with the new input names:
Details
PR #1677 change how AWS ECR was referenced in order to support an AWS ECR public registry. The input to the custom git hub actions,
combine-buildandcombine-deploy-update, that specifies the image registry to use was changed; the singleimage_repoinput was changed toimage_registryandimage_registry_alias.The implementation of this change was not complete. The required updates to the
combine-deploy-updatewere missed. This PR completes the required changes.Closes #1679
This change is