Docker image for deploy #1683
Merged
Docker image for deploy #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 52.21% 52.32% +0.11%
==========================================
Files 275 275
Lines 8498 8498
Branches 616 616
==========================================
+ Hits 4437 4447 +10
+ Misses 3568 3558 -10
Partials 493 493
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
imnasnainaec
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Reviewed 5 of 7 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Docker image to simplify deploying The Combine in a Windows environment.
The Docker image contains the tools necessary to install The Combine on a separate target system, such as a NUC. It includes:
deploy/scriptsdeploy/ansible/deploy/helm/deploy/scriptsdeploy/scripts/setup_target.pythat sets up the target system in/etc/hostson the Docker container, generates an SSH key, and copies the key to the target system.In addition, the configuration for
cert-proxy-serveris updated to generate a certificate for a 3rd NUC,nuc3.thecombine.app. This required removing thetractor.pngfrom the ConfigMap that initializes the web pages for the nginx server; the image made the ConfigMap too large to be managed byhelm.Issue #1687 has been created to capture the need to update the README file for deploying The Combine to describe how to use the Docker image.
This change is