Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataEntryTable] Use preventDefault in TextField #1712

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 18, 2022

Resolves #1711 by preventing Safari's default of triggering the Exit button when the "return" key is pressed within a TextField. This solution does not identify the root of that wonky behavior, but does avoid it.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Aug 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1712 (12e4ca5) into master (a19dd6a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
- Coverage   52.18%   52.17%   -0.02%     
==========================================
  Files         275      275              
  Lines        8502     8504       +2     
  Branches      616      616              
==========================================
  Hits         4437     4437              
- Misses       3572     3574       +2     
  Partials      493      493              
Flag Coverage Δ
backend 80.22% <ø> (ø)
frontend 32.64% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Table/EntryCellComponents/GlossWithSuggestions.tsx 37.50% <0.00%> (-2.50%) ⬇️
...yTable/EntryCellComponents/VernWithSuggestions.tsx 36.36% <0.00%> (-3.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@jasonleenaylor jasonleenaylor merged commit 540dfd4 into master Aug 18, 2022
@jasonleenaylor jasonleenaylor deleted the data-entry-safari branch August 18, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataEntry] In Safari, "return" exits user back to tree instead of submitting new entry
3 participants