Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing public registry alias to update of combine-cert-proxy #1716

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

jmgrady
Copy link
Collaborator

@jmgrady jmgrady commented Aug 23, 2022

Missing ${{ inputs.image_registry_alias }} when updating the combine-cert-proxy deployment results in an invalid image name being specified for the deployment.


This change is Reviewable

@jmgrady jmgrady added bug Something isn't working CI/CD labels Aug 23, 2022
@jmgrady jmgrady self-assigned this Aug 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #1716 (3a8d2db) into master (540dfd4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1716   +/-   ##
=======================================
  Coverage   52.17%   52.17%           
=======================================
  Files         275      275           
  Lines        8504     8504           
  Branches      616      616           
=======================================
  Hits         4437     4437           
  Misses       3574     3574           
  Partials      493      493           
Flag Coverage Δ
backend 80.22% <ø> (ø)
frontend 32.64% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...viewEntries/ReviewEntriesComponent/CellColumns.tsx 59.63% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@jmgrady jmgrady merged commit 8b17829 into master Aug 24, 2022
@jmgrady jmgrady deleted the cert-proxy-update branch August 24, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants