Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for full question structure or flattened questions #1727

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

jmgrady
Copy link
Collaborator

@jmgrady jmgrady commented Sep 7, 2022

Add an option to the sem_dom_import.py script to specify whether the questions section of each semantic domain should be full or flat (default). As an example:

  • Full:

     "questions": [
         {
             "question": "(1) What words are used to refer to the sky?",
             "example_words": "sky, firmament, canopy, vault",
             "example_sentences": ""
         },
         {
             "question": "(2) What words refer to the air around the earth?",
             "example_words": "air, atmosphere, airspace, stratosphere, ozone layer",
             "example_sentences": ""
         },
         ...
    
  • Flat:

     "questions": [
         "(1) What words are used to refer to the sky?",
         "(2) What words refer to the air around the earth?",
         ...
    

This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

Base: 51.98% // Head: 79.69% // Increases project coverage by +27.71% 🎉

Coverage data is based on head (1ff27a1) compared to base (32a5277).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1727       +/-   ##
===========================================
+ Coverage   51.98%   79.69%   +27.71%     
===========================================
  Files         278       39      -239     
  Lines        8637     3576     -5061     
  Branches      620        0      -620     
===========================================
- Hits         4490     2850     -1640     
+ Misses       3650      726     -2924     
+ Partials      497        0      -497     
Flag Coverage Δ
backend 79.69% <ø> (ø)
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/UserSettings/UserSettings.tsx
src/goals/HandleFlags/HandleFlags.ts
...on/components/CharacterList/CharacterSetHeader.tsx
...viewEntriesComponent/CellComponents/DeleteCell.tsx
src/components/LandingPage/BottomBar.tsx
src/components/GoalTimeline/index.ts
...viewEntriesComponent/Redux/ReviewEntriesReducer.ts
...mponents/ProjectSettings/ProjectUsers/UserList.tsx
src/components/AppBar/ProjectNameButton.tsx
...nents/ProjectSettings/ProjectUsers/EmailInvite.tsx
... and 229 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@jmgrady jmgrady merged commit 73b56e6 into master Sep 7, 2022
@jmgrady jmgrady deleted the flatten-questions branch September 7, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants