Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration script #1749

Merged
merged 2 commits into from
Oct 22, 2022
Merged

Update migration script #1749

merged 2 commits into from
Oct 22, 2022

Conversation

jmgrady
Copy link
Collaborator

@jmgrady jmgrady commented Oct 22, 2022

Update database migration script for updating SemanticDomains field of the senses in the FrontierCollection and the WordsCollection.

  • Adds _id field for the MongoDB ObjectId for the document in the SemanticDomains collection. If the semantic domain id and name do not match any of the domains in the collection, null is used;
  • Changes the guid field from a UUID type to str type to match the SemanticDomains collection and the data model.
  • Reverts the change to the script to update the SemanticDomains collection to use the merge mode instead of upsert so that only changed documents are updated.

This change is Reviewable

@jmgrady jmgrady added bug Something isn't working python labels Oct 22, 2022
@jmgrady jmgrady self-assigned this Oct 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2022

Codecov Report

Base: 51.38% // Head: 51.44% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (8922383) compared to base (721a3ee).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
+ Coverage   51.38%   51.44%   +0.05%     
==========================================
  Files         277      277              
  Lines        8569     8569              
  Branches      630      630              
==========================================
+ Hits         4403     4408       +5     
+ Misses       3661     3656       -5     
  Partials      505      505              
Flag Coverage Δ
backend 79.11% <ø> (+0.14%) ⬆️
frontend 32.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Backend/Helper/DuplicateFinder.cs 88.76% <0.00%> (+2.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@jmgrady jmgrady merged commit dc00920 into master Oct 22, 2022
@jmgrady jmgrady deleted the migration-script branch October 22, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants