Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node from 16 to 18 #1809

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Update node from 16 to 18 #1809

merged 6 commits into from
Mar 21, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 10, 2023

This change is Reviewable

@imnasnainaec imnasnainaec added docker dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jan 10, 2023
@imnasnainaec imnasnainaec self-assigned this Jan 10, 2023
@imnasnainaec imnasnainaec marked this pull request as draft January 10, 2023 17:46
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (fc0503d) 49.49% compared to head (88f1a74) 49.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1809      +/-   ##
==========================================
+ Coverage   49.49%   49.52%   +0.03%     
==========================================
  Files         292      292              
  Lines        9102     9102              
  Branches      663      663              
==========================================
+ Hits         4505     4508       +3     
+ Misses       4058     4055       -3     
  Partials      539      539              
Flag Coverage Δ
backend 74.03% <ø> (+0.07%) ⬆️
frontend 31.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imnasnainaec imnasnainaec marked this pull request as ready for review March 17, 2023 18:17
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@jmgrady jmgrady merged commit c0370d9 into master Mar 21, 2023
@jmgrady jmgrady deleted the node18 branch March 21, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants