Replace uses of alert with SnackBar(toast) #1928
Conversation
fuencui
added
the
maintenance
There was a problem hiding this comment.
This looks good. I wonder if we can reduce the code duplication. I think we have some files which contain sharable components or methods where the handleToastUpdate can go.
Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @fuencui)
Codecov ReportBase: 50.37% // Head: 50.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1928 +/- ##
=======================================
Coverage 50.37% 50.38%
=======================================
Files 286 286
Lines 8887 8888 +1
Branches 651 651
=======================================
+ Hits 4477 4478 +1
Misses 3882 3882
Partials 528 528
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Reviewed 4 of 9 files at r2, 5 of 5 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @fuencui)
src/goals/ReviewEntries/ReviewEntriesComponent/ReviewEntriesTable.tsx line 44 at r5 (raw file):
return ( <React.Fragment>
Do we still need this Fragment now that you are using notistack?
Code quote:
<React.Fragment>
There was a problem hiding this comment.
Reviewed 4 of 4 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @fuencui)
There was a problem hiding this comment.
Reviewed 7 of 7 files at r7, all commit messages.
Reviewable status:
Implement a SnackBar component to replace the native JS alert for DataEntryTable, ExportButton, UserSettings, ReviewEntriesTable.
This change is