Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair front end unit tests #2

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Repair front end unit tests #2

merged 1 commit into from
Jun 5, 2019

Conversation

Micah-Schiewe
Copy link
Contributor

@Micah-Schiewe Micah-Schiewe commented Jun 5, 2019

This change is Reviewable

Copy link
Contributor

@Rapdorian Rapdorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


src/components/Temp/tests/TempActions.test.tsx, line 33 at r1 (raw file):

      .then(() => {
        expect(mockStore.getActions()).toEqual([bP]);
        expect(axios.post).toHaveBeenCalled();

It would be nice if we could make sure this called the right route not just that it called a route


src/components/Temp/tests/mocks/axios.ts, line 1 at r1 (raw file):

export default {

Would it be handy to record what routes have been called so we can make sure things are calling the right routes?

@Micah-Schiewe Micah-Schiewe merged commit 97bb972 into master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants