Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataEntry cleanup #2051

Merged
merged 3 commits into from
Apr 18, 2023
Merged

DataEntry cleanup #2051

merged 3 commits into from
Apr 18, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 17, 2023

Resolves part of #2048


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.02 ⚠️

Comparison is base (b7ba947) 49.78% compared to head (9e0be2a) 49.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2051      +/-   ##
==========================================
- Coverage   49.78%   49.77%   -0.02%     
==========================================
  Files         294      294              
  Lines        9184     9180       -4     
  Branches      666      666              
==========================================
- Hits         4572     4569       -3     
+ Misses       4072     4069       -3     
- Partials      540      542       +2     
Flag Coverage Δ
backend 74.16% <ø> (+0.07%) ⬆️
frontend 32.38% <60.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/DataEntry/DataEntryComponent.tsx 45.45% <33.33%> (+3.78%) ⬆️
...onents/DataEntry/DataEntryTable/DataEntryTable.tsx 47.08% <100.00%> (-0.20%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit fb27058 into master Apr 18, 2023
@imnasnainaec imnasnainaec deleted the data-entry-tests branch April 18, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants