Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sweetalert2 to remove protestware #2055

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Pin sweetalert2 to remove protestware #2055

merged 1 commit into from
Apr 19, 2023

Conversation

jmgrady
Copy link
Collaborator

@jmgrady jmgrady commented Apr 19, 2023

Pin sweetalert2 to version 11.4.8 - version before protestware was added. Verified that sweetalert2 announcements are displayed as before.


This change is Reviewable

@jmgrady jmgrady added bug Something isn't working dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 19, 2023
@jmgrady jmgrady self-assigned this Apr 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fb27058) 49.73% compared to head (1c8036f) 49.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2055   +/-   ##
=======================================
  Coverage   49.73%   49.73%           
=======================================
  Files         294      294           
  Lines        9180     9180           
  Branches      666      666           
=======================================
  Hits         4566     4566           
  Misses       4072     4072           
  Partials      542      542           
Flag Coverage Δ
backend 74.08% <ø> (ø)
frontend 32.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@jmgrady jmgrady merged commit cd8f611 into master Apr 19, 2023
@jmgrady jmgrady deleted the pin-sweetalert2 branch April 19, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants