Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For i18n ui langauges, add Portuguese and fallbacks #2140

Merged
merged 6 commits into from
May 17, 2023
Merged

For i18n ui langauges, add Portuguese and fallbacks #2140

merged 6 commits into from
May 17, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented May 9, 2023

This change is Reviewable

@imnasnainaec imnasnainaec marked this pull request as ready for review May 12, 2023 18:58
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (ca31782) 49.52% compared to head (5e7efa8) 49.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2140      +/-   ##
==========================================
+ Coverage   49.52%   49.53%   +0.01%     
==========================================
  Files         294      294              
  Lines        9493     9494       +1     
  Branches      694      694              
==========================================
+ Hits         4701     4703       +2     
+ Misses       4237     4236       -1     
  Partials      555      555              
Flag Coverage Δ
backend 72.08% <ø> (ø)
frontend 33.46% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/i18n.ts 0.00% <ø> (ø)
src/types/writingSystem.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imnasnainaec imnasnainaec enabled auto-merge (squash) May 12, 2023 19:03
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 42cbb26 into master May 17, 2023
@imnasnainaec imnasnainaec deleted the pt branch May 17, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants