-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically en-/dis-able definitions #2161
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2161 +/- ##
===========================================
+ Coverage 49.50% 72.04% +22.54%
===========================================
Files 294 43 -251
Lines 9494 3957 -5537
Branches 694 0 -694
===========================================
- Hits 4700 2851 -1849
+ Misses 4239 1106 -3133
+ Partials 555 0 -555
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Pull request was converted to draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 11 files at r1, 10 of 10 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
Backend.Tests/Controllers/LiftControllerTests.cs
line 489 at r2 (raw file):
Assert.That(proj.DefinitionsEnabled, Is.True); }
The only difference that I can see between these two functions is the file to be imported and the expected result. Wouldn't it be easier to maintain if there was a single function to perform this task which receives the filename and expected result as arguments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jmgrady)
Backend.Tests/Controllers/LiftControllerTests.cs
line 489 at r2 (raw file):
Previously, jmgrady (Jim Grady) wrote…
The only difference that I can see between these two functions is the file to be imported and the expected result. Wouldn't it be easier to maintain if there was a single function to perform this task which receives the filename and expected result as arguments?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #2145
Once deployed, something like the following should be run on the server:
This change is