Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataEntryTable] NewEntry refactor #2166

Merged
merged 24 commits into from
May 23, 2023
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented May 16, 2023

Setting the stage for #2137

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this May 16, 2023
@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. component: DataEntry labels May 16, 2023
@imnasnainaec imnasnainaec marked this pull request as ready for review May 19, 2023 19:21
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 11 files at r1, all commit messages.
Reviewable status: 10 of 11 files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/components/DataEntry/DataEntryTable/DataEntryTable.tsx line 688 at r1 (raw file):

  /***  Checks if sense already exists with this gloss and semantic domain. */
  const updateWordWithNewEntry = async (wordId: string): Promise<void> => {
    const oldWord = state.allWords.find((w: Word) => w.id === wordId);

I'm not sure if oldWord is better than existingWord, but if existingWord wasn't helpful for you then it is probably a good change.


src/components/DataEntry/DataEntryTable/DataEntryTable.tsx line 928 at r1 (raw file):

            type="submit"
            variant="contained"
            color={state.newVern.trim() ? "primary" : "secondary"}

:) nice simplification

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Patch coverage: 53.26% and project coverage change: +0.36 🎉

Comparison is base (fa20365) 57.49% compared to head (110e0fe) 57.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2166      +/-   ##
==========================================
+ Coverage   57.49%   57.85%   +0.36%     
==========================================
  Files         241      242       +1     
  Lines        7740     7740              
  Branches      500      497       -3     
==========================================
+ Hits         4450     4478      +28     
+ Misses       2911     2893      -18     
+ Partials      379      369      -10     
Flag Coverage Δ
backend 73.04% <ø> (ø)
frontend 42.34% <53.26%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../DataEntry/DataEntryTable/NewEntry/SenseDialog.tsx 0.00% <0.00%> (-11.12%) ⬇️
...s/DataEntry/DataEntryTable/NewEntry/VernDialog.tsx 62.50% <ø> (-4.17%) ⬇️
...yTable/EntryCellComponents/VernWithSuggestions.tsx 40.00% <16.66%> (ø)
...nts/DataEntry/DataEntryTable/NewEntry/NewEntry.tsx 40.22% <38.09%> (+21.47%) ⬆️
...onents/DataEntry/DataEntryTable/DataEntryTable.tsx 50.00% <71.91%> (-0.88%) ⬇️
...ataEntry/DataEntryTable/NewEntry/StyledMenuItem.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 11 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) May 23, 2023 20:07
@imnasnainaec imnasnainaec merged commit 9ff37ed into master May 23, 2023
@imnasnainaec imnasnainaec deleted the data-entry-table-defunct branch May 23, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DataEntry frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants