-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataEntryTable] NewEntry refactor #2166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 11 files at r1, all commit messages.
Reviewable status: 10 of 11 files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/components/DataEntry/DataEntryTable/DataEntryTable.tsx
line 688 at r1 (raw file):
/*** Checks if sense already exists with this gloss and semantic domain. */ const updateWordWithNewEntry = async (wordId: string): Promise<void> => { const oldWord = state.allWords.find((w: Word) => w.id === wordId);
I'm not sure if oldWord is better than existingWord, but if existingWord wasn't helpful for you then it is probably a good change.
src/components/DataEntry/DataEntryTable/DataEntryTable.tsx
line 928 at r1 (raw file):
type="submit" variant="contained" color={state.newVern.trim() ? "primary" : "secondary"}
:) nice simplification
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2166 +/- ##
==========================================
+ Coverage 57.49% 57.85% +0.36%
==========================================
Files 241 242 +1
Lines 7740 7740
Branches 500 497 -3
==========================================
+ Hits 4450 4478 +28
+ Misses 2911 2893 -18
+ Partials 379 369 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 11 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Setting the stage for #2137
This change is