Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup coverage #2170

Merged
merged 7 commits into from
May 18, 2023
Merged

Cleanup coverage #2170

merged 7 commits into from
May 18, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented May 17, 2023

Towards #2169

This change is Reviewable

@imnasnainaec imnasnainaec added the maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. label May 17, 2023
@imnasnainaec imnasnainaec self-assigned this May 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +7.73 🎉

Comparison is base (4bef76b) 49.56% compared to head (20d7015) 57.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2170      +/-   ##
==========================================
+ Coverage   49.56%   57.29%   +7.73%     
==========================================
  Files         293      244      -49     
  Lines        9494     7714    -1780     
  Branches      694      498     -196     
==========================================
- Hits         4706     4420     -286     
+ Misses       4233     2914    -1319     
+ Partials      555      380     -175     
Flag Coverage Δ
backend 73.13% <ø> (+1.08%) ⬆️
frontend 41.06% <ø> (+7.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/backend/index.ts 12.30% <ø> (ø)
...onents/DataEntry/DataEntryTable/DataEntryTable.tsx 50.87% <ø> (ø)
...nts/DataEntry/DataEntryTable/NewEntry/NewEntry.tsx 18.75% <ø> (ø)
.../DataEntry/DataEntryTable/NewEntry/SenseDialog.tsx 11.11% <ø> (ø)
...taEntry/DataEntryTable/RecentEntry/RecentEntry.tsx 47.82% <ø> (ø)
.../components/GoalTimeline/GoalTimelineComponent.tsx 64.10% <ø> (ø)
src/components/GoalTimeline/Redux/GoalActions.ts 79.74% <ø> (ø)
...rc/components/Login/SignUpPage/SignUpComponent.tsx 47.82% <ø> (ø)
...c/components/PasswordReset/ResetPage/component.tsx 42.85% <ø> (ø)
src/components/ProjectExport/DownloadButton.tsx 37.50% <ø> (ø)
... and 8 more

... and 52 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imnasnainaec imnasnainaec marked this pull request as ready for review May 17, 2023 20:53
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 52 of 58 files at r1, 29 of 29 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit eb1a4b8 into master May 18, 2023
@imnasnainaec imnasnainaec deleted the codecov branch May 18, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants