Improve AppBar #2190
Improve AppBar #2190
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2190 +/- ##
==========================================
- Coverage 57.99% 57.86% -0.14%
==========================================
Files 242 242
Lines 7745 7746 +1
Branches 497 498 +1
==========================================
- Hits 4492 4482 -10
- Misses 2884 2893 +9
- Partials 369 371 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 8 of 10 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status: 9 of 10 files reviewed, 2 unresolved discussions (waiting on @imnasnainaec)
src/components/AppBar/ProjectNameButton.tsx line 35 at r2 (raw file):
/** A button that redirects to the project settings */ export default function ProjectNameButton(
Insert appropriate new name here. My namer is malfunctioning, so I can't help right now.
Code quote:
ProjectNameButtonsrc/components/DataEntry/DataEntryComponent.tsx line 106 at r2 (raw file):
componentDidMount(): void { this.props.openTree();
? Did we break this earlier?
There was a problem hiding this comment.
Reviewable status: 7 of 11 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jasonleenaylor)
src/components/DataEntry/DataEntryComponent.tsx line 106 at r2 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
? Did we break this earlier?
No, I added it here to remove the dispatch in AppBar/NavigationButtons.
There was a problem hiding this comment.
Reviewed 3 of 4 files at r3, 4 of 4 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Remove hard-coded grid size specifications to allow buttons to shift and fit more dynamically.
Restore small Combine icon for narrow windows, as it's the only way to get back to the ProjectScreen without logging out and back in again.
Fix max height of app-bar to prevent vertical stretching when "DATA ENTRY" or "DATA CLEANUP" overflow to third line in localization.
To save space on narrow windows, move Statistics button from large "DATA STATISTICS" nav button to small stats-icon button next to project settings.
With these changes:
Admins and project-owners have no AppBar overflow with window width at least 347 pixels;
Non-admin, non-project-owner users have no AppBar overflow with window width at least 302 pixels.
This change is