Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL and host config for local kubernetes cluster #2271

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

jmgrady
Copy link
Collaborator

@jmgrady jmgrady commented Jun 12, 2023

Update the instructions for setting up The Combine on a local Kubernetes cluster in README.md. Specifically:

  1. Changed the URL for The Combine from https://thecombine.local to https://thecombine.localhost. This URL change was made sometime ago since Google Chrome, Chromium Derivatives, and Firefox automatically map *.localhost to 127.0.0.1.
  2. Removed instructions for updating the host machine's host configuration file.

This change is Reviewable

@jmgrady jmgrady added documentation Improvements or additions to documentation kubernetes labels Jun 12, 2023
@jmgrady jmgrady self-assigned this Jun 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -14.41 ⚠️

Comparison is base (4202d78) 73.23% compared to head (f1e5486) 58.82%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2271       +/-   ##
===========================================
- Coverage   73.23%   58.82%   -14.41%     
===========================================
  Files          42      235      +193     
  Lines        3923     7767     +3844     
  Branches        0      502      +502     
===========================================
+ Hits         2873     4569     +1696     
- Misses       1050     2827     +1777     
- Partials        0      371      +371     
Flag Coverage Δ
backend 73.23% <ø> (ø)
frontend 44.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 193 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@jmgrady jmgrady merged commit 814d4a5 into master Jun 12, 2023
@jmgrady jmgrady deleted the update-readme branch June 12, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants